ryan1685 said:
All adapters were bought from luna cycle. I didn't solder anything. I will get the mm. I was riding the bike 5 minutes before this happened. I switched the battery when I got home which entailed unplugging everything. That is when I had the issue with the connector tried straightening the pins but failed without noticing . Plugged in the battery than boom. Only thing that changed was the bent pin. Having 3 pins bent onto each other much have closed some type of circuit that bypassed the power switch and caused it to ignight the second I plugged in the battery . Imo
What changed was the battery. I know it sounds crazy, but it's not unheard of for a battery from aliexpress coming reverse wired for polarity. If you plugged it in then, it could have fried and created a direct short in your controller (based on your diagram, the battery wires go directly to the motor housing and controller).
The cable going to the display carries battery voltage for two reasons. To allow the display to show the battery level or voltage, and to turn the bike on and off. Even factory bikes work this way. It may or may not have played into the initial problem.
Once the controller was fried/shorted, plugging your old battery in would subject it to the same short, and poof.
This is just a theory, but easy to diagnose with even a $5 meter from Harbor Freight. You've provided good clear pictures, and decent information with respect to what happened, but I think to get to the bottom of the problem, you need a way to take measurements. That's the missing piece, and as much as it frustrates you, it frustrates folks trying to help as well.