casainho said:
@rananna, I was able to build, everything is ok, that was a problem of my side because I changed computer and I was missing some tools.
Did you actually go for a ride, or was this bench testing?
casainho said:
1. walk assist works as expected and is nice that green LED flashing while it is active
OK, that one is ready to go!
casainho said:
2. at motor startup, if I look at the mobile app, seems that the remote is taking more time to stop LEDs, so, effectively extending the motor turn on time that is already to long!! Why not stop the LEDs as soon motor is on?
Well, actually, that is not the case. Both @beemac's code, my code and the Android code are recognizing the turn on time at the same time.
What maybe is giving the sense that it is taking longer is we are using a short green, short green, long green sequence to indicate motor on. I have changed this to a double green flash. It now lines up well with the android app in time.
casainho said:
Here you blink red and green at the same time. Did you tested to alternate blink? like when one if on the other is off? I would expect more visual impact and I think that motor startup needs critical attention from the user, otherwise the torque sensor calibration will fail can make the ebike run without pedaling, so it is dangerous.
Good idea. I changed this to alternating red and blue LEDS to avoid confusion with thee green led when thee motor is on. I think this is better
casainho said:
When decreasing the assist level, the red LED is enable while only should be the green (and no, there is no color mixing on the LEDs, I see spots for each color)
I changed assist down to be the same as assist up. both now green.
casainho said:
4. see battery state while clicking on on/off button is nice. I do not like to be forced to see battery state every time I turn off the motor, and even it seems to increase the motor turn off time
now removed on power off
casainho said:
the brake LED signal is now a blinking red. Blinking and red should be used for future alerts / fatal errors because it caches even more our attention compared to solid red only. I think the brakes should be a solid red and maybe with max duration of 5 seconds, so if I keep brakes pressed for 2 minutes at a red light stop, only 5 seconds of power will be used from the battery
for now, I implemented a solid red when brake is on.
In another pr I will implement a timer to turn off after 5 seconds.
@beemac - I tried to do this with a led sequence, but a delay will always play out. please look at this PR, and LED_SEQUENCE_EXTRA_LONGRED . Any ideas on how we could do this for the brake?
casainho said:
6. I like the amount of brightness for the LEDs, I tested during day and seems good.
good. we are getting there.
I just gave you a PR with these changes