Crank length effects a number of things, some less relevant on an ebike some more. For pedaling the length generally depends on how long your legs are. The reasons I went with shorter cranks (in order of importance) was increased body motion and comfort, less pedal strikes when starting from a stop, and weight reduction. When your feet are close together you have better range of motion in your legs and hips. I was surprised how much but it's easy to try, just stand with your feet side by side and crouch then move your feet forward and back like they were on pedals and try crouching again, you'll find you can't comfortably crouch nearly as far.
The problem though is finding cranks that are reasonably priced and fit your BB. That can be a real pain, my bike uses a front freewheel so I needed threaded trials cranks which may have made it easier as I was able to find 150mm Jitsie cranks pretty easily. Keep in mind I am quite short so that may be too short for you to be comfortable to pedal.
Generally I'm standing up all the time while riding but I have been working on an experimental lightweight 3D printed suspension seatpost for those smoother areas to rest my legs a bit.
The problem though is finding cranks that are reasonably priced and fit your BB. That can be a real pain, my bike uses a front freewheel so I needed threaded trials cranks which may have made it easier as I was able to find 150mm Jitsie cranks pretty easily. Keep in mind I am quite short so that may be too short for you to be comfortable to pedal.
Generally I'm standing up all the time while riding but I have been working on an experimental lightweight 3D printed suspension seatpost for those smoother areas to rest my legs a bit.