casainho
10 GW
- Joined
- Feb 14, 2011
- Messages
- 6,058
I did the thresholds implementation. And first I was using PWM max 254 but later changed to 0 - 100, as it is easy to understand 0 - 100%.mbrusa said:I think that whoever developed this piece of software has made choices, evaluating utilities / resources used, choices that I share.
The only variable for which there is no threshold and which instead would be very useful to have it is the engine power, on this I agree with you.
I will add this threshold with automatic operation, the maximum motor power can be set with different values and also changes with street enable / disable.
Two notes:
- The value of "motor current" is not the current of the motor, but the same value of "battery current". I kept the variable active even if not used, because it is present in the choice of numeric fields and graphs.
- I already wrote it in the previous post, the PWM max is no longer 100 but 254. I will have to change the PWM thresholds, warning (yellow) and error (red).
If I would implement the thresholds today and variables on the graphs, I would make also as a percentage, like motor power to be 0 - 100% and would be easy for user to understand how near is the max of motor power, meaning to not expect more assistance if motor is already at 100% of any of the variables.
I have plans to implement this same concepts of thresholds for the Garmin fields: numeric fields, gauge fields and graphics fields. The same could also be implemented on the mobile app that currently has only numeric fields.
And battery current and motor current are different, there are limitations for both to keep the motor controller safe. There was plan to have a ramp for both that currents, for keep in safe all the parts, motor controller, the plastic gear and battery pack.