beemac
10 kW
casainho said:You need to improve as you "deleted" code that was working, like the code for brakes I did recently and I tested as working as is part of the latest release. And there are changes like to the SDC config file!! You need to review your PR, I did some notes on the PR, you should get notifications.beemac said:@casainho, @rananna - having a nightmare with this PR for some reason. I could not resolve a conflict I had in pins.c - despite my change just being to add 4 lines that weren't there before. So I just made a fresh branch - and added my changes to it by copying the changed files in from my original branch. That's what the current PR contains - and finally with no merge conflicts.
*but* I was reviewing the PR and it looks like it will back out some changes about ANT page 16 in main.c that I didn't make - not sure how that occurred.
I assume another PR was accepted in the short time between me pulling a fresh branch - and overwriting the files I'd changed...?
https://github.com/OpenSourceEBike/TSDZ2_wireless/pull/63/files
Hey - i'm doing my best - the previous post was to alert you to the fact that something unexpected happened. I'm not a professional developer and working in a distributed source code environment is new to me.
Changes to the SDK config file are needed to enable features in the NRF SDK i believe - I took them from rananna's remote codebase.
I done another PR - taking your comments into consideration. Hopefully i'm getting there...