Anyways original one is for bafang, so who cares it will never work with tongshengobcd said:Isn't the original firmware protected against readout? If it's the case, we don't have it so you can't restore it.
HughF said:I will flash the new 36v-HC code and go for another spin tomorrow.
Excellent - set the current ramp to maximum (10a), went and did another 20k - great performance. I am going to get my hands on my luggage scales on Wednesday then I can calibrate the torque sensor.r0mko said:HughF said:I will flash the new 36v-HC code and go for another spin tomorrow.
How'd it go?
casainho said:New firmware release v0.8.0
Download here: https://github.com/OpenSource-EBike-firmware/Color_LCD/releases/tag/860C_850C_SW102_v0.8.0
Changelog:
- corrected the long delay that motor took to stop after stop pedaling (thank to mbrusa)
- added street mode with quick configuration from display main screen
- added motor max power limit with quick configuration from display main screen
- added internal battery resistance automatic calculation
- corrected issue on motor selection type (thanks to r0mko)
- added negative torque signal for braking that should apply only to TSDZ2 coast brake version (thanks to plpetrov)
- corrected an issue where 860C display buttons were configured to be the same as 850C (no M button usage)
ezrider1199 said:Just tested the firmware out. The absence of motor overrun is a great feeling. Found a bug - I had the motor lurch at assist 0 when pedaling off the seat. Another bug - throttle is definitely *broken* in this release. When you try to accelerate with the throttle, it starts jerking as if power keeps coming on and off. Also at assist 0, i was getting a trickle (very little) power when using the throttle. Please please fix!
HughF said:r0mko, any plans to add the overrun fix to your quick and dirty torque mode release?
casainho said:New firmware release v0.8.0
Download here: https://github.com/OpenSource-EBike-firmware/Color_LCD/releases/tag/860C_850C_SW102_v0.8.0
1. I could not replicate yet the changes I did, one of them did not consider the assist level 0. Should be solved now.ezrider1199 said:1. Found a bug - I had the motor lurch at assist 0 when pedaling off the seat.
2. Another bug - throttle is definitely *broken* in this release. When you try to accelerate with the throttle, it starts jerking as if power keeps coming on and off. Also at assist 0, i was getting a trickle (very little) power when using the throttle. Please please fix!
I am now start to thinking on the new feature that is let user being able to disable the sensors:r0mko said:Perhaps it makes sense to integrate the torque mode back into the new firmware, but it seems to have some issues, so for now I'd better stick to the v0.56 FW with torque mode and figure out what is the actual overrun fix among other code changes.HughF said:r0mko, any plans to add the overrun fix to your quick and dirty torque mode release?
Yes, you were right about the throttle - it is fixed now.vshitikov said:I think this is because of the overrun. @Casainho, did you check the original fix from mbrusa. He had to modify ebike_app.c in order not to use overrrun fix when throttle is configured, otherwise it cuts the power if user is not pedaling.
Another question, did you managed to sort what user plpetrov had reported with weird behaviour at assist levels greater than 10?
Thank you
casainho said:I will make this release and then I hope we can solve this issues, including the ones for coast brake version BUT I don't have one, I really need your help.
Can you please configure the pedal to start at right side and then test to see if the same happens?
casainho said:I am now start to thinking on the new feature that is let user being able to disable the sensors:r0mko said:Perhaps it makes sense to integrate the torque mode back into the new firmware, but it seems to have some issues, so for now I'd better stick to the v0.56 FW with torque mode and figure out what is the actual overrun fix among other code changes.HughF said:r0mko, any plans to add the overrun fix to your quick and dirty torque mode release?
- torque sensor
- cadence sensor
- brake sensor
- wheel speed sensor
So, when user decides to disable the cadence sensor, then the system should work with torque sensor mode. The contrary for when the user disables the torque sensor, then the system should work with cadence. When both disable (like when with issues like broke pedal or issue on pedal cranks), then system will be able to work with the throttle or virtual throttle.
So my plan is to implement:
- sensors disable by user
- torque mode
- cadence mode
- virtual throttle
Did you try to see if you get higher values of ADC at other points different from the calibration points? I remember to test at least one torque sensor and I would get higher values outside of calibration point, where I expect that to not happen!! I guess this is a (bad) characteristic of the torque sensor... and if this happens, then part of the issue can be here? Can you test your torque sensor values?plpetrov said:Based on this, I can suggest that may be we need to take into account the delta in the torque sensor value for 0 load between the right and left pedal. May be better the max and the min values that are different than the ones at the point we do the calibration. How exactly I do not know. May be in the linearisation function to shift the 0 value of one of the pedals or to calculate the average value and subtract it from the pedal with higher value and add the same to the pedal with lower value. This could be the easies solution to implement. If it will work I have an idea of other simple solutions but they may have other side effects.
Do you want me to test the current release also? Which tests you would prefer to be preformed and what data you need?
I like the sound of this, it sounds like a sensible way forward.casainho said:I am now start to thinking on the new feature that is let user being able to disable the sensors:r0mko said:Perhaps it makes sense to integrate the torque mode back into the new firmware, but it seems to have some issues, so for now I'd better stick to the v0.56 FW with torque mode and figure out what is the actual overrun fix among other code changes.HughF said:r0mko, any plans to add the overrun fix to your quick and dirty torque mode release?
- torque sensor
- cadence sensor
- brake sensor
- wheel speed sensor
So, when user decides to disable the cadence sensor, then the system should work with torque sensor mode. The contrary for when the user disables the torque sensor, then the system should work with cadence. When both disable (like when with issues like broke pedal or issue on pedal cranks), then system will be able to work with the throttle or virtual throttle.
So my plan is to implement:
- sensors disable by user
- torque mode
- cadence mode
- virtual throttle
casainho said:Did you try to see if you get higher values of ADC at other points different from the calibration points? I remember to test at least one torque sensor and I would get higher values outside of calibration point, where I expect that to not happen!! I guess this is a (bad) characteristic of the torque sensor... and if this happens, then part of the issue can be here? Can you test your torque sensor values?
- both left and right pedals usually have the same ADC values for 0 KG on the calibration point
- at least some torque sensors measure higher values outside of the calibration point, which I think should not happen
It is not the case with me. On the left pedal I have 134 and on the right pedal I have 140. The delta is 6.casainho said:- both left and right pedals usually have the same ADC values for 0 KG on the calibration point"
Again not my case.casainho said:- at least some torque sensors measure higher values outside of the calibration point, which I think should not happen
It is related to some peculiarities of my torque sensor. See my answer to Casainho. However I doubt that I am the only one with this problem. In my opinion it is there with everyone but in my case is very well represented as I am reaching some extremes due to the sum of two unexpected conditions.vshitikov said:Hello
I just flashed all the latest FW and the display and performed a quick test run. All seems to work fine, I don't see any regression or problems but I haven't tested all the configurations as I don't have throttle.
The problems that user Plpetrov is reporting with the quick motor bursts: I do not observe it in the real run. I think it might be related to the testing with the rear wheel up. When I test like this motor spins very fast because it has no wheel resistance and it is quickly pushing the rear wheel to the maximum speed. So I think there is no real problem with the FW. Plpetrov you migh test it on the real run.
What do you mean by max of 140 when the calibration value is 134?plpetrov said:Again not my case.casainho said:- at least some torque sensors measure higher values outside of the calibration point, which I think should not happen
On the left pedal I have at the calibration point 134 with maximum of 140. The delta is 6.
On the right side I have at the calibration point 140 with maximum of 143. The delta is 3.
Yes this is exactly my case with the left pedal. At the calibration point I have 134 with the maximum of 140 while on the display I still read left side.casainho said:What do you mean by max of 140 when the calibration value is 134?plpetrov said:Again not my case.casainho said:- at least some torque sensors measure higher values outside of the calibration point, which I think should not happen
On the left pedal I have at the calibration point 134 with maximum of 140. The delta is 6.
On the right side I have at the calibration point 140 with maximum of 143. The delta is 3.
plpetrov said:Yes this is exactly my case with the left pedal. At the calibration point I have 134 with the maximum of 140 while on the display I still read left side.casainho said:What do you mean by max of 140 when the calibration value is 134?plpetrov said:Again not my case.casainho said:- at least some torque sensors measure higher values outside of the calibration point, which I think should not happen
On the left pedal I have at the calibration point 134 with maximum of 140. The delta is 6.
On the right side I have at the calibration point 140 with maximum of 143. The delta is 3.
I did two more tests to try to find a solution. The are maybe not the best ones but does not require programming.
Test 1. I changed the calibration values for 0 with the maximum for each side. That improved the situation a lot. Left side 140 right side 143.
Test 2. I tried to equalise the both calibration values changing both to 143. Did not like the result very close to the original problem.
Test 3. Desided to take a value at the middle. Both set to 139. Very good but still improvement to be desired.